On Thu, 2016-12-01 at 16:07 +0100, Artem Savkov wrote: > I am not, but this would have the same behavior as pre-07b26c9 code and > IS_ERR_OR_NULL is used in ipv4's inet_gso_segment().
My concern might have been that IS_ERR_OR_NULL() considers the !ptr to be unlikely. But in this code path, we really can not tell. segs == NULL can be quite likely in TUN case, because of DODGY bit Commit 50c3a487d50756 replaced the perfectly fine : if (!segs || IS_ERR(segs)) into dubious if (IS_ERR_OR_NULL(segs)) segs = NULL is not an error, but use of IS_ERR_OR_NULL() might mislead programmers trying to understand this code.
