I don't think we should disable and enable all interrupts in the poll_controller entry point. With the current patch, at the end of the routine _all_ interrupts get enabled which is not desirable. Maybe you should just do disable_irq() at start of function and enable_irq() before exiting, the way some of the other drivers do.
Ravi -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Brian Haley Sent: Thursday, June 08, 2006 9:02 AM To: netdev@vger.kernel.org Cc: [EMAIL PROTECTED] Subject: [PATCH] s2io: netpoll support This adds netpoll support for things like netconsole/kgdboe to the s2io 10GbE driver. This duplicates some code from s2io_poll() as I wanted to be least-invasive, someone from Neterion might have other thoughts? Signed-off-by: Brian Haley <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
