From: Eric Dumazet <eric.duma...@gmail.com> Date: Sat, 26 Nov 2016 18:16:00 -0800
> On Sun, 2016-11-27 at 00:47 +0200, Saeed Mahameed wrote: >> On Fri, Nov 25, 2016 at 5:46 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > >> As you see here in SRIOV mode (PF only) reads sw stats from FW. >> Tariq, I think we need to fix this. > > Sure, my patch does not change this at all. > > If mlx4_is_master() is false, then we aggregate the software states and > only the software stats. > > My patch makes this aggregation possible at the time ethtool or > ndo_get_stat64() are called, since this absolutely not depend on the 250 > ms timer fetching hardware stats. Saeed please provide counter arguments or ACK this patch, thank you.