From: "Michael Chan" <[EMAIL PROTECTED]> Date: Mon, 12 Jun 2006 18:42:29 -0700
> On Mon, 2006-06-12 at 17:38 -0700, David Miller wrote: > > From: "Michael Chan" <[EMAIL PROTECTED]> > > Date: Mon, 12 Jun 2006 17:17:18 -0700 > > > > > Add functions to decompress firmware before loading to the internal > > > CPUs. Compressing the firmware reduces the driver size significantly. > > > > > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> > > ... > > > +#define FNAME 0x8 > > > + if (zbuf[3] & FNAME) > > > + while (zbuf[n++] != 0); > > > > This can potentially loop past the end of zbuf[], so maybe > > put a sanity check against 'len' and return non-zero if we > > traverse past the end? > > Add functions to decompress firmware before loading to the internal > CPUs. Compressing the firmware reduces the driver size significantly. > > Added file name length sanity check in the gzip header to prevent > going past the end of buffer [suggested by DaveM]. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> This looks great, applied. Thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html