On Wed, Nov 23, 2016 at 10:24:47AM -0500, John W. Linville wrote: > It looks like this patch somehow misses the following commit: > > commit 85a624403c77c3f074931aefdfced59f61b668cb > Author: Jesse Brandeburg <jesse.brandeb...@intel.com> > Date: Thu Oct 13 16:13:55 2016 -0700 > > ethtool: silence warning on bit loss > > Sparse was complaining when we went to prototype some code > using ethtool_cmd_speed_set and SPEED_100000, which uses > the upper 16 bits of __u32 speed for the first time. > > CHECK > ... > .../uapi/linux/ethtool.h:123:28: warning: > cast truncates bits from constant value (186a0 becomes 86a0) > > The warning is actually bogus, as no bits are really lost, but > we can get rid of the sparse warning with this one small change. > > Reported-by: Preethi Banala <preethi.ban...@intel.com> > Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com> > Signed-off-by: David S. Miller <da...@davemloft.net> > > Plus, the referenced commit does not seem to exist in the net-next tree. > > Please resubmit with the complete history and correct commit IDs -- thanks!
I mean, of course, all the preceding changes accounted for -- not every commit explicitly listed. The top commit does, of course, need to reflect the correct commit ID from Dave's/Linus's tree. John -- John W. Linville Someday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.
