On 11/21/16, 10:14 PM, Zhang Shengju wrote: > For RT netlink, calcit() function should return the minimal size for > netlink dump message. This will make sure that dump message for every > network device can be stored. > > Currently, rtnl_calcit() function doesn't account the size of header of > netlink message, this patch will fix it. > > Signed-off-by: Zhang Shengju <zhangshen...@cmss.chinamobile.com> > --- > net/core/rtnetlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > index f4b9350..09e115b 100644 > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -2734,7 +2734,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct > nlmsghdr *nlh) > ext_filter_mask)); > } > > - return min_ifinfo_dump_size; > + return nlmsg_total_size(min_ifinfo_dump_size); > } > > static int rtnl_dump_all(struct sk_buff *skb, struct netlink_callback *cb)
This looks fine to me. However, looking at the git log, since this code has been around for so long, it seems like it can go into net-next. But, that's just my 2c.
