Re: [PATCH 4/5] virtio_net: add dedicated XDP transmit queues

[Jakub Kicinski]

Looks very cool! :)

On Fri, 18 Nov 2016 11:00:41 -0800, John Fastabend wrote:
> @@ -1542,12 +1546,34 @@ static int virtnet_xdp_set(struct net_device *dev, 
> struct bpf_prog *prog)
>               return -EINVAL;
>       }
>  
> +     curr_qp = vi->curr_queue_pairs - vi->xdp_queue_pairs;
> +     if (prog)
> +             xdp_qp = num_online_cpus();

Is num_online_cpus() correct here?