On 11/9/16 7:48 PM, David Miller wrote: > From: David Ahern <d...@cumulusnetworks.com> > Date: Tue, 8 Nov 2016 14:50:31 -0800 > >> Lorenzo noted an Android unit test failed due to commit e0d56fdd7342: >> "The expectation in the test was that the RST replying to a SYN sent to a >> closed port should be generated with oif=0. In other words it should not >> prefer the interface where the SYN came in on, but instead should follow >> whatever the routing table says it should do." >> >> Since this a change in behavior, revert the change to >> ip_send_unicast_reply such that the oif in the flow is set to the skb_iif >> only if skb_iif is an L3 master. >> >> Fixes: e0d56fdd7342 ("net: l3mdev: remove redundant calls") >> Reported-by: Lorenzo Colitti <lore...@google.com> >> Signed-off-by: David Ahern <d...@cumulusnetworks.com> > > David, I'm assuming that a new spin of this patch is coming. >
yes. posted this morning; Lorenzo tested and ack'ed an hour or so ago. Since it expanded to include IPv6, the subject line changed so it won't be readily apparent.