On 04/11/16 13:13, Andrew Lunn wrote: > On Fri, Nov 04, 2016 at 11:35:39AM +0100, Allan W. Nielsen wrote: > > From: Raju Lakkaraju <raju.lakkar...@microsemi.com> > > > > Adding get_tunable/set_tunable function pointer to the phy_driver > > structure, and uses these function pointers to implement the > > ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE ioctls. > For consistency, it would also be nice to add code in > __ethtool_get_strings(). Okay, we add add that, and I assume you also want ethtool to use it when the "-k|--show-features" options is invoked?
Are there other cases where this should be used? /Allan