On Wed, Nov 02, 2016 at 08:18:51PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/02/2016 08:08 PM, Jon Mason wrote: > > >Clean-up the documentation to the bgmac-amac driver, per suggestion by > >Rob Herring, and add details for NS2 support. > > > >Signed-off-by: Jon Mason <jon.ma...@broadcom.com> > >--- > > Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++++++++++----- > > 1 file changed, 11 insertions(+), 5 deletions(-) > > > >diff --git a/Documentation/devicetree/bindings/net/brcm,amac.txt > >b/Documentation/devicetree/bindings/net/brcm,amac.txt > >index ba5ecc1..2fefa1a 100644 > >--- a/Documentation/devicetree/bindings/net/brcm,amac.txt > >+++ b/Documentation/devicetree/bindings/net/brcm,amac.txt > >@@ -2,11 +2,17 @@ Broadcom AMAC Ethernet Controller Device Tree Bindings > > ------------------------------------------------------------- > > > > Required properties: > >- - compatible: "brcm,amac" or "brcm,nsp-amac" > >- - reg: Address and length of the GMAC registers, > >- Address and length of the GMAC IDM registers > >- - reg-names: Names of the registers. Must have both "amac_base" and > >- "idm_base" > >+ - compatible: "brcm,amac" > >+ "brcm,nsp-amac" > >+ "brcm,ns2-amac" > >+ - reg: Address and length of the register set for the device. > >It > >+ contains the information of registers in the same order as > >+ described by reg-names > >+ - reg-names: Names of the registers. > >+ "amac_base": Address and length of the GMAC registers > >+ "idm_base": Address and length of the GMAC IDM registers > >+ "nicpm_base": Address and length of the NIC Port Manager > >+ registers (required for Northstar2) > > Why this "_base" suffix? It looks redundant...
Yes. Rob Herring pointed out the same thing. It is ugly, but follows the existing binding. Thanks, Jon > > [...] > > MBR, Sergei >
