I managed to miss that sk_for_each is called under "for"
cycle so need to use goto here to return matching socket.

CC: David S. Miller <da...@davemloft.net>
CC: Eric Dumazet <eric.duma...@gmail.com>
CC: David Ahern <d...@cumulusnetworks.com>
CC: Andrey Vagin <ava...@openvz.org>
CC: Stephen Hemminger <step...@networkplumber.org>
Signed-off-by: Cyrill Gorcunov <gorcu...@openvz.org>
---
 net/ipv4/raw_diag.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-ml.git/net/ipv4/raw_diag.c
===================================================================
--- linux-ml.git.orig/net/ipv4/raw_diag.c
+++ linux-ml.git/net/ipv4/raw_diag.c
@@ -79,10 +79,11 @@ static struct sock *raw_sock_get(struct
                                 * hashinfo->lock here.
                                 */
                                sock_hold(sk);
-                               break;
+                               goto out_unlock;
                        }
                }
        }
+out_unlock:
        read_unlock(&hashinfo->lock);
 
        return sk ? sk : ERR_PTR(-ENOENT);

Reply via email to