On Mon, Jun 05, 2006 at 09:32:50PM -0700, David Miller wrote: > > IPOIB is going to BUG() with this change. Because now, in their > multicast code, you're going to local_bh_disable() via > netif_tx_unlock() with hw IRQs disabled which is illegal. > > It shows a bug here in the locking of the IPOIB driver.
You had me woried there. > We need to think about this change some more. :) I thought about it a bit more and I'm not worried anymore :) Notice that the patch does netif_tx_lock/netif_tx_unlock for IB instead of netif_tx_lock_bh/netif_tx_unlock_bh. So there is no BH enabling going on at all. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
