Herbert Xu wrote: > The paths where full lock is preceded by netif_tx_disable are > obviously > safe (well, once you take off the LLTX flag anyway). > However, there are > paths that don't do netif_tx_disable (e.g., tg3_set_rx_mode), are they > safe as well? >
In places where we don't call tg3_netif_stop() before tg3_full_lock(), we are typically doing one of the following: - changing tg3_flags or tg3_flags2 - reprogramming MAC address - reprogramming interrupt coalescing values - reprogramming the PHY - setting the rx mode The TX code does not do any of these so it is safe. tg3_set_rx_mode() is actually called with xmit_lock held through dev->set_multicast_list(). Or it is called after tg3_netif_stop() in the VLAN registration calls (in my patch #3). - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
