Re: [PATCH net-next 1/3] net: core: Add a UID field to struct sock.

[David Miller]

From: Eric Dumazet <eric.duma...@gmail.com>
Date: Thu, 27 Oct 2016 10:36:26 -0700

> On Fri, 2016-10-28 at 02:20 +0900, Lorenzo Colitti wrote:
> 
>> diff --git a/net/core/sock.c b/net/core/sock.c
>> index d8e4532e..831e4e8 100644
>> --- a/net/core/sock.c
>> +++ b/net/core/sock.c
>> @@ -1570,6 +1570,7 @@ struct sock *sk_clone_lock(const struct sock *sk, 
>> const gfp_t priority)
>>               */
>>              sk_refcnt_debug_inc(newsk);
>>              sk_set_socket(newsk, NULL);
>> +            newsk->sk_uid = sk->sk_uid;
> 
> Not sure why this is needed ?
> 
> sk_clone_lock() already copies sk to newsk, using sock_copy(newsk, sk);

Agreed.