On Mon, 5 Jun 2006 15:09:45 -0400 (EDT) Ananda Raju <[EMAIL PROTECTED]> wrote:
> Hi, > Neterion Xframe adapter supports TSO over IPv6 but the linux kernel > don't support TSO over Ipv6. This patch will allow TCP > Segmentation Offload (TSO) packets to be created over IPv6. > > The following table shows there is significant improvement in > throughput with normal frames and CPU usage for both normal and jumbo. > > -------------------------------------------------- > | | 1500 | 9600 | > | ------------------|-------------------| > | | thru CPU | thru CPU | > -------------------------------------------------- > | TSO OFF | 1.80 2.0% id | 5.53 1.0% id | > -------------------------------------------------- > | TSO ON | 2.61 74.0 id | 5.52 32.0% id | > -------------------------------------------------- > > Please review the patch. There is one problem that may mean you have to rethink this. You ignore the possible case of hardware that can do any kind of checksum (ie. IP_F_HW_CSUM). So I think you need to add a new flag NETIF_F_TSO6 for those types of devices, rather than overloading NETIF_F_TSO to mean "can do TCP segmentation offload for IPV4 or IPV6". Your proposal: ipv4 sum : NETIF_F_IP_CSUM ipv6 sum : NETIF_F_IP6_CSUM hw sum : NETIF_F_HW_CSUM tso, ipv4 : NETIF_F_IP_CSUM + NETIF_F_TSO tso, ipv6 : NETIF_F_IP6_CSUM + NETIF_F_TSO My proposal: ipv4 sum : NETIF_F_IP_CSUM ipv6 sum : NETIF_F_IP6_CSUM hw sum : NETIF_F_HW_CSUM tso, ipv4 : NETIF_F_IP_CSUM + NETIF_F_TSO tso, ipv6 : NETIF_F_IP6_CSUM + NETIF_F_TSO6 tso, hw : NETIF_F_HW_CSUM + NETIF_F_TSO6 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html