> [snip]
>> @@ -440,12 +448,12 @@ static void macsec_fill_sectag(struct 
>> macsec_eth_header *h,
>>                             const struct macsec_secy *secy, u32 pn)
>>  {
>>      const struct macsec_tx_sc *tx_sc = &secy->tx_sc;
>> +    bool sci_present = send_sci(secy);
> 
> You're already computing this in macsec_encrypt() just before calling
> macsec_fill_sectag(), so you could pass it as argument instead of
> recomputing it.

Right, I'll send a v2.  Would you like me to inline the send_sci()
function, as it will only be called once afterwards.

Regards,
Tobias

Reply via email to