On Wed, May 31, 2006 at 05:27:53PM -0700, Michael Chan wrote: > > Now that I think about it some more, we can eliminate most of the > tx_lock in tg3 without converting to xmit_lock. In most places, we get > the tx_lock after we call netif_tx_disable(), etc, and quiesce the chip. > So the tx_lock or xmit_lock is really not necessary in most places. The > tp->lock is sufficient after we stop everything.
Sounds good. > The only few remaining places where we need it is around > netif_stop_queue/netif_wake_queue in hard_start_xmit and tx completion. > We can either keep the tx_lock or convert to xmit_lock and either way > makes little difference because these are not in the normal fast path. > If we keep the tx_lock, it will be just like BNX2. Now that I look at it the BNX2 method looks perfect. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
