On Tue, May 30, 2006 at 09:13:22PM -0700, David Miller wrote: > > There were numbers posted for real drivers at one point, I > do remember that, and the gains were non-trivial. At least > enough to justify the feature.
I wonder if there are other ways of achieving the same improvement. > As per the bug, I always keep thinking about changing how we > do the lockless stuff by simply making xmit_lock a pointer. > Drivers like tg3 can make it point to their local driver lock. This is equivalent to just using the xmit_lock in the driver, right? IIRC the problem was with IRQ disabling vs. BH disabling. That's why I suggest that every NIC that uses this feature be forced to do what TG3 does so only BH disabling is needed. Once that's done they can just use xmit_lock and everyone will be happy again. > This leaves still the cases like loopback which do no locking > whatsoever. I don't know how to fit it into the above idea. As far as I'm concerned loopback can do whatever it wants as long as it doesn't create bugs in real NICs :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
