From: Jaedon Shin <jaedon.s...@gmail.com> Date: Sat, 24 Sep 2016 06:08:19 +0900
> This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev > from struct net_device") > > without this patch, we call twice bcmgenet_mii_reset, and that is intended: > - first time from bcmgenet_power_up() to make sure the PHY is initialized > *before* we get to initialize the UniMAC, this is critical > - second time from bcmgenet_mii_probe(), through the normal phy_init_hw() > > with this patch, we only get to call bcmgenet_mii_reset once, in > bcmgenet_mii_probe() because the first time in bcmgenet_power_up(), > dev->phydev is NULL, because of a prior call to phy_disconnect() in > bcmgenet_close(), unfortunately, there has been MAC activity, so the PHY > gets in a bad state > > Signed-off-by: Jaedon Shin <jaedon.s...@gmail.com> This is needed by the ksettings commit that happened right after this one, so if you want this reverted you have to revert both commits.