On Thu, 2016-09-22 at 21:27 +0300, Shmulik Ladkani wrote: > On Thu, 22 Sep 2016 07:54:13 -0700 Eric Dumazet <eric.duma...@gmail.com> > wrote: > > Hmm... we probably need to apply the full rcu protection before this > > patch. > > > > https://patchwork.ozlabs.org/patch/667680/ > > Are you referring to order of application into net-next? > > This patch seems to present no new tcf_mirred_params members nor > need-to-be-protected code regions (please, correct me if wrong). > So it does not _depend_ on the 'full rcu fixes', does it?
No, simply a reminder that we run lockless there, so you might need to read some control variables once, and in a consistent way. (Or a concurrent writer could change params in the middle of the function)
