> > include/uapi/rdma/providers/qedr-abi.h | 35 + > > Please be aware that the last version for ABI header files doesn't have > "provider" > name in directory path (include/uapi/rdma/qedr-abi.h)
OK. Note that I was using https://www.spinics.net/lists/linux-rdma/msg40414.html that dates to 7 days ago and it contains the "providers" folder. Can you point to the most recent patch? > > diff --git a/drivers/infiniband/hw/qedr/main.c > > b/drivers/infiniband/hw/qedr/main.c > > index c99dd6a..10ad9ed 100644 > > --- a/drivers/infiniband/hw/qedr/main.c > > +++ b/drivers/infiniband/hw/qedr/main.c > > @@ -52,7 +52,7 @@ uint debug; > > module_param(debug, uint, 0); > > MODULE_PARM_DESC(debug, "Default debug msglevel"); > > > > -static LIST_HEAD(qedr_dev_list); > > You are removing code which was added in previous patches, why do you do it? > Sure. Will fix. Thanks. > > diff --git a/drivers/infiniband/hw/qedr/qedr.h > > b/drivers/infiniband/hw/qedr/qedr.h > > index dd974d5..05017be 100644 > > --- a/drivers/infiniband/hw/qedr/qedr.h > > +++ b/drivers/infiniband/hw/qedr/qedr.h > > @@ -49,6 +49,9 @@ > > enum DP_QEDR_MODULE { > > QEDR_MSG_INIT = 0x10000, > > We prefer shift notation (1 << 16) instead of 0x10000. > OK, I'll convert accordingly.
