On Fri, 26 May 2006, Paul Moore wrote: > There may be an issue with packets generated by the kernel directly and > not as a result of an incoming packet but I can't think of a case where > this would happen (although I suspect I am just not thinking hard > enough). Do you have a scenario in mind?
There are several possibilities, I believe. The networking code would need to be audited to find them all. > Okay. I suspect this code will go away, but just for my own education > were you thinking of something like this? > > static inline int my_func(void) > #ifdef CONFIG_NETLABEL_CIPSOV4 > /* real stuff */ > #else > /* compile away into a zero */ > return 0; > #endif > } > > ... or something else? No. You put the real function in a .c file and the dummy inline in a .h file. There are many examples of this in the kernel. > > - Why does this module have a version number? > > > > + printk(KERN_INFO "NetLabel: Initializing (v%s %s)\n", > > + NETLBL_VER_STR, NETLBL_VER_DATE); > > > > The version number is there primarily to help signal possible > differences in the NetLabel netlink protocol. How will this ever help anything? If you change that protocol, userspace applications will break, which is not acceptable. You can add versioning at the protocol level or via adding a new netlink family in the future, but existing apps cannot break and you need to maintain compatibility. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
