> Restart autoneg if autoneg is enabled. > + if (!(link_info->autoneg & BNXT_AUTONEG_SPEED)) > + return -EINVAL;
Looks like a lot of the of implementations of this ethtool are unconditionally doing the reset. Perhaps the right thing to do is check for autoneg availability at the ethtool core itself? [Not an objection to this patch in any way as there are tens of implementations doing the same; Simply noting this]