Hi, On Sun, Sep 18, 2016 at 04:39:47PM +0800, Baoyou Xie wrote: > We get 3 warnings when building kernel with W=1: > drivers/net/ethernet/mellanox/mlxsw/spectrum.c:251:29: warning: no previous > prototype for 'mlxsw_sp_span_entry_find' [-Wmissing-prototypes] > drivers/net/ethernet/mellanox/mlxsw/spectrum.c:265:29: warning: no previous > prototype for 'mlxsw_sp_span_entry_get' [-Wmissing-prototypes] > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:1749:6: warning: no > previous prototype for 'mlxsw_sp_fib_entry_put' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie <baoyou....@linaro.org>
Thanks for the patch! We already have a patch that fixes sparse warnings (including these) queued up. See: https://github.com/jpirko/linux_mlxsw/commit/4800ed89f5da55a42a173d5cf9225d4fbb8a96bd But since we already have one patch under review we've yet to submit it. https://patchwork.ozlabs.org/patch/670846/ Do you mind dropping this and instead let our patch (with the rest of the fixes) go through? Thanks, Ido.
