On 09/14/2016 11:52 PM, Richard Cochran wrote: > On Wed, Sep 14, 2016 at 11:37:45PM +0300, Grygorii Strashko wrote: >> The problem is that if cpts not initialized than pinter on >> cpts (in consumer/parent driver - NETCP) will be NULL. > > You made that problem with your "clean up" in this series. > Previously, cpts was always allocated.
not exactly - it was allocated in CPSW .probe() manually, in without this re-work it has to be allocated in NTCP the same way - manually. So, checks we are discussing here will be still present, but they will need to be done in CPSW/NETCP drivers - just one level up and duplicated in both these drivers. > >> So, rx_enable will be unaccessible and cause crash :( > > So just make sure cpts is initialized. OK. I'll update code this way. -- regards, -grygorii
