On Wed, Sep 14, 2016 at 04:02:26PM +0300, Grygorii Strashko wrote: > Move DT properties parsing into CPTS driver to simplify consumer's > code and CPTS driver porting on other SoC in the future > (like Keystone 2).
And just who is the consumer? > Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> > --- > drivers/net/ethernet/ti/cpsw.c | 16 +--------------- > drivers/net/ethernet/ti/cpsw.h | 2 -- > drivers/net/ethernet/ti/cpts.c | 29 ++++++++++++++++++++++++++--- > drivers/net/ethernet/ti/cpts.h | 5 +++-- > 4 files changed, 30 insertions(+), 22 deletions(-) You have more (+) than (-). I wouldn't call that a simplification. Thanks, Richard