On 09/13/2016 08:59 AM, Andrew Lunn wrote: >> Hi Andrew, >> >> this function does indeed duplicate the functionality of >> phy_ethtool_get_eee() with the small difference, that e->eee_active is >> also set which phy_ethtool_get_eee() does not set. >> >> dsa_slave_get_eee() will call phy_ethtool_get_eee() right after the >> get_eee() op has been called. would it be ok to move the code setting >> eee_active to phy_ethtool_get_eee().
Humm, AFAIR, the reason why eee_active is set outside of phy_ethtool_set_eee() is because this is a MAC + PHY thing, both need to agree and support that, and so while the PHY may be configured to have EEE advertised and enabled, you also need to take care of the MAC portion and enable EEE in there as well. Is not there such a thing for the qca8k switch where the PHY needs to be configured through the standard phylib calls, but the switch's transmitter/receiver also needs to have EEE enabled? -- Florian
