On 16-09-12 07:40 PM, Eric Dumazet wrote:
On Mon, 2016-09-12 at 19:30 -0400, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
+
+static struct tc_action_ops act_skbmod_ops = {
+ .kind = "skbmod",
+ .type = TCA_ACT_SKBMOD,
+ .owner = THIS_MODULE,
+ .act = tcf_skbmod_run,
+ .dump = tcf_skbmod_dump,
+ .init = tcf_skbmod_init,
+ .walk = tcf_skbmod_walker,
+ .lookup = tcf_skbmod_search,
+ .size = sizeof(struct tcf_skbmod),
+};
Looks like you missed a .cleanup() handler ?
Otherwise, d->skbmod_p wont be freed .
Yes, I did ;->
Another version coming. Is there a good way to catch
something like this (ala userspace valgrind)?
cheers,
jamal
