On 16-09-12 01:18 PM, Cong Wang wrote:
On Mon, Sep 12, 2016 at 3:21 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
+ if (ovr)
+ a->tcfa_refcnt-=1;
How about tcfa_bindcnt?
We dont touch it when mucking around only with actions (as is in
this case).
+ }
+}
+
int tcf_action_init(struct net *net, struct nlattr *nla,
struct nlattr *est, char *name, int ovr,
int bind, struct list_head *actions)
@@ -612,8 +622,15 @@ int tcf_action_init(struct net *net, struct nlattr *nla,
goto err;
}
act->order = i;
+ if (ovr)
Need to check this boolean? It looks like we need this for !ovr case too?
They are fine if they didnt exist.
I will fix the coding style issues and submit.
cheers,
jamal
