On 16-09-08 08:35 AM, Eric Dumazet wrote:
> From: Eric Dumazet <eduma...@google.com>
>
> As reported by Cong Wang, I was lazy when I did initial RCU conversion
> of tc_mirred, as I thought I could avoid allocation/freeing of a
> parameter block.
>
> Use an intermediate object so that fast path can get a consistent
> snapshot of multiple variables (dev, action, eaction, ok_push)
>
> Fixes: 2ee22a90c7af ("net_sched: act_mirred: remove spinlock in fast path")
> Signed-off-by: Eric Dumazet <eduma...@google.com>
> Reported-by: Cong Wang <xiyou.wangc...@gmail.com>
> Cc: John Fastabend <john.fastab...@gmail.com>
> Cc: Jamal Hadi Salim <j...@mojatatu.com>
> Cc: Hadar Hen Zion <had...@mellanox.com>
> Cc: Amir Vadai <ami...@mellanox.com>
> ---
Works for me. FWIW I find this plenty straightforward and don't really
see the need to make the hash table itself rcu friendly.
Acked-by: John Fastabend <john.r.fastab...@intel.com>
