On Wed, Sep 7, 2016 at 7:14 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Wed, 2016-09-07 at 11:08 +0300, Hadar Hen Zion wrote: >> From: Amir Vadai <a...@vadai.me> >> > > >> +static int tunnel_key_init(struct net *net, struct nlattr *nla, >> + struct nlattr *est, struct tc_action **a, >> + int ovr, int bind) >> +{ >> + struct tc_action_net *tn = net_generic(net, tunnel_key_net_id); >> + struct nlattr *tb[TCA_TUNNEL_KEY_MAX + 1]; >> + struct metadata_dst *metadata = NULL; >> + struct tc_tunnel_key *parm; >> + struct tcf_tunnel_key *t; >> + struct tcf_tunnel_key_params *params_old; >> + struct tcf_tunnel_key_params *params_new; >> + __be64 key_id; >> + bool exists = false; >> + int ret = 0; >> + int err; > > We try for new code to avoid reverse Christmas tree ;)
Fix checkpatch.pl (or whatever tool you prefer).