Hello, On Wed, Aug 17, 2016 at 10:50:40AM -0700, Alexei Starovoitov wrote: > > +config CGROUP_BPF > > + bool "Enable eBPF programs in cgroups" > > + depends on BPF_SYSCALL > > + help > > + This options allows cgroups to accommodate eBPF programs that > > + can be used for network traffic filtering and accounting. See > > + Documentation/networking/filter.txt for more information. > > + > > I think this extra config is unnecessary. It makes the code harder to follow. > Anyone turning on bpf syscall and cgroups should be able to have this feature. > Extra config is imo overkill.
Agreed, the added code is pretty small, especially in comparison to both cgroup and bpf, and the only memory overhead would be four pointers per cgroup, which shouldn't be noticeable at all. Thanks. -- tejun
