On Mon, Aug 15, 2016 at 02:16:51AM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 10, 2016 at 05:24:34PM +0200, ggar...@abra.uab.cat wrote: > > From: Gerard Garcia <ggar...@deic.uab.cat> > > > > Remove unnecessary use of enable/disable callback notifications > > and the incorrect more space available check. > > > > The virtio_transport_tx_work handles when the TX virtqueue > > has more buffers available. > > > > Signed-off-by: Gerard Garcia <ggar...@deic.uab.cat> > > Acked-by: Stefan Hajnoczi <stefa...@redhat.com> > > Generally enable/disable is a worthwhile optimization, > but if Stefan wants to keep code simple for now, > I don't have a problem with that.
Enabling/disabling callbacks is inappropriate in this function because its job is *submitting* buffers rather than *reclaiming* completed buffers. Oops, I'm not sure how this mistake crept in :). The callback suppression should only be done around the loop that reclaims buffers. Doing it in the wrong place leads to hangs if interrupts are lost. Stefan
signature.asc
Description: PGP signature
