On 16-08-08 04:46 PM, Cong Wang wrote:
This patchset fixes several regressions caused by the previous code refactor. Thanks to Jamal for catching them!
Cong, Good news: oops gone. I havent done more testing than I did before; but looks good so far. Bad news: You have introduced a performance regression which is noticeable at high speed. tcf_exts_exec() is the culprit - and conversion to from flexarray to linked list in the fast problem to be specific. The regression is problematic (and unacceptable). Two options: a) You fix the regressions - which i think may require changing what gets passed around an executed on as an array instead of a list. b) I am worried #a will take some work. So the second option is to back out the patch since there are known stability options; get regression issues resolved and then go back and submit. cheers, jamla
