On 8/5/2016 2:38 PM, Julia Lawall wrote:
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
---
drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 7b8fe86..a77ba98 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device
*pdev)
goto err_ioremap;
}
- if (of_get_property(pdev->dev.of_node,
- "little-endian", NULL))
+ if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
priv->is_little_endian = true;
else
priv->is_little_endian = false;
priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
"little-endian"));
Thanks,
I just sent a v2 with this change.
I've seen. Sorry, forgot to look at the followups before commenting...
julia
MBR, Sergei
