[EMAIL PROTECTED] wrote:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=6530
> 
>            Summary: MAINLINE
>     Kernel Version: 2.6.16
>             Status: NEW
>           Severity: normal
>              Owner: [EMAIL PROTECTED]
>          Submitter: [EMAIL PROTECTED]
> 
> 
> Most recent kernel where this bug did not occur:
> Distribution:  gentoo 2005.1
> Hardware Environment: i386 (Intel(R) Celeron(R) M processor         1.40GHz), 
> RAM 256M
> Software Environment:
> Problem Description:
> Hello.
> I tried to setup pptp (pptpd) service on my linux box, but it don't work 
> correctly.
> Problem: traffic freezes when sending large amount of data.
> 
> I find lack in ppp_async.c. 
> 
>       /* try to push more stuff out */
>       if (test_bit(XMIT_WAKEUP, &ap->xmit_flags) && ppp_async_push(ap))
>               ppp_output_wakeup(&ap->chan);
> ---->> I added this lines and pptpd starts work.
>       else
>       {
>           if (test_bit(XMIT_FULL, &ap->xmit_flags))
>               ppp_asynctty_wakeup(ap->tty);
>       }
> 

hm, a PPP fix.  We seem to need some of those lately.

Paul, does this look sane?


From: <[EMAIL PROTECTED]>

Adapted from  http://bugzilla.kernel.org/show_bug.cgi?id=6530

Reschedule the async Tx tasklet if the transmit queue was full.

Cc: Paul Mackerras <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/ppp_async.c |    2 ++
 1 files changed, 2 insertions(+)

diff -puN drivers/net/ppp_async.c~ppp_async-hang-fix drivers/net/ppp_async.c
--- devel/drivers/net/ppp_async.c~ppp_async-hang-fix    2006-05-10 
02:28:15.000000000 -0700
+++ devel-akpm/drivers/net/ppp_async.c  2006-05-10 02:28:53.000000000 -0700
@@ -516,6 +516,8 @@ static void ppp_async_process(unsigned l
        /* try to push more stuff out */
        if (test_bit(XMIT_WAKEUP, &ap->xmit_flags) && ppp_async_push(ap))
                ppp_output_wakeup(&ap->chan);
+       else if (test_bit(XMIT_FULL, &ap->xmit_flags))
+               ppp_asynctty_wakeup(ap->tty);
 }
 
 /*
_

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to