On 1.8.2016 16:20, David Laight wrote:
From: Ivan Vecera
Sent: 29 July 2016 18:53
Change type of bna_id to atomic_t. The bnad_list_mutex is used to prevent
a race when bna_id is incremented. After the change the mutex can be
removed in the next step.
...
-static u32 bna_id;
+static atomic_t bna_id;
...
bnad_lock_init(bnad);
bnad_add_to_list(bnad);
+ bnad->id = atomic_inc_return(&bna_id) - 1;
...
Is the 'id' expected to be unique?
Looks like they get reallocated after 2^32 allocates.
David
I have just converted it to atomic type to eliminate mutex. The id is
only used as parameter 'instance' for bfa_nw_flash_{update,read}_part().
There is no documentation in source code regarding this so this is a
question to Qlogic.
Ivan
