Hau <h...@realtek.com> : [...] > > Either the driver resumes the device so that it can perform requested > > operation or it signals .set_wol failure when the device is suspended. > > > > If the driver does something else, "spam removal" translates to "silent > > failure". > > Because "tp->saved_wolopts" will be used to set hardware wol capability in > rtl8169_runtime_resume(). So I prefer to keep "wol->wolopts" to > " tp->saved_wolopts " in runtime suspend state and set this to this > "wol->wolopts" to hardware in in rtl8169_runtime_resume().
It would be fine if it could be proven that rtl8169_runtime_resume() will always be run before software state is lost. -- Ueimor
