On Wed, Jul 27, 2016 at 08:44:15AM +0200, Vegard Nossum wrote: > On 07/27/2016 08:31 AM, Herbert Xu wrote: > >On Wed, Jul 27, 2016 at 08:20:57AM +0200, Vegard Nossum wrote: > >> > >>Here's another patch to remove that too. > >> > >>I don't actually *use* this code myself and I feel the justification > >>I've given for removing the WARN to be a bit weak, so if you don't take > >>the patch I'll just keep it in my local tree to keep it from showing up > >>again during fuzzing. > > > >Please just kill the whole else clause. For soft policy expires > >we simply need to relay a message to the KM and nothing more. > > Try #2 :-) > > > Vegard
> >From e5111e4dcd0e0c0990d3f4bba0ba0bc9d0b40bae Mon Sep 17 00:00:00 2001 > From: Vegard Nossum <vegard.nos...@oracle.com> > Date: Wed, 27 Jul 2016 08:13:14 +0200 > Subject: [PATCH] xfrm: get rid of another incorrect WARN > > During fuzzing I regularly run into this WARN(). According to Herbert Xu, > this "certainly shouldn't be a WARN, it probably shouldn't print anything > either". > > Cc: Stephen Hemminger <step...@networkplumber.org> > Cc: Steffen Klassert <steffen.klass...@secunet.com> > Cc: Herbert Xu <herb...@gondor.apana.org.au> > Signed-off-by: Vegard Nossum <vegard.nos...@oracle.com> Also applied to the ipsec tree, thanks a lot!
