Hi Ingo:
On Mon, May 08, 2006 at 03:22:14PM +0200, Ingo Oeser wrote:
>
> you wrote:
> > diff --git a/include/net/xfrm.h b/include/net/xfrm.h
> > --- a/include/net/xfrm.h
> > +++ b/include/net/xfrm.h
> > @@ -204,8 +204,7 @@ struct xfrm_type;
> > ?struct xfrm_dst;
> > ?struct xfrm_policy_afinfo {
> > ????????unsigned short??????????family;
> > -???????rwlock_t????????????????lock;
> > -???????struct xfrm_type_map????*type_map;
> > +???????struct xfrm_type????????*type_map[256];
>
> What does this magic number "256" mean? I guess we need either
> a comment or a proper constant here. I prefer the latter.
It's just moving an existing line down if you look further up in
the patch. Of couse I would have nothing against a patch that
replaced 256 with IPPROTO_MAX or something.
However, I prefer to not mix clean-ups with substantive changes so
if you have the time please post a separate patch for this. Otherwise
I'll do a patch when I resubmit this.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
