From: Wei Yongjun <yongjun_...@trendmicro.com.cn>

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
---
 drivers/net/ethernet/broadcom/bgmac-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c 
b/drivers/net/ethernet/broadcom/bgmac-platform.c
index 7a8f7ef..1a2d841 100644
--- a/drivers/net/ethernet/broadcom/bgmac-platform.c
+++ b/drivers/net/ethernet/broadcom/bgmac-platform.c
@@ -141,7 +141,7 @@ static int bgmac_probe(struct platform_device *pdev)
        }
 
        bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs);
-       if (!bgmac->plat.idm_base) {
+       if (IS_ERR(bgmac->plat.idm_base)) {
                dev_err(&pdev->dev, "Unable to map idm resource\n");
                return PTR_ERR(bgmac->plat.idm_base);
        }


Reply via email to