>On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan <tar...@mellanox.com> wrote: >> From: Moshe Shemesh <mo...@mellanox.com> >> >> Separate QUERY_FUNC_CAP flags0 from QUERY_FUNC_CAP flags. >> Remove QUERY_FUNC_CAP port_flags field which was not in use. > >The patch title says "Fix ..." but the change log doesn't say if this is >fixing real bug, or cleaning up dead >code, nor you point to the commit you >are fixing, please add that, I guess it is something we do wrong >w.r.t the >PHV bit but I am not clear what.
Both dead code and a bug: One part is removing dead code (unused field - port_flags). "Remove QUERY_FUNC_CAP port_flags field which was not in use." The other part is fixing a bug, as "flags" is already used for other set of flags in Func cap, while phv bit should be part of a different set of flags "flags0". "Separate QUERY_FUNC_CAP flags0 from QUERY_FUNC_CAP flags." We will submit v2 with an updated commit massage including the relevant Fixes lines. Regards, Moshe.
