>>> On 07.07.16 at 13:12, <david.vra...@citrix.com> wrote: > The better clean-up is to remove xenbus_write() in favour of > xenbus_printf() everywhere (especially since one of your "cleanups" made > it worse).
I don't think I've seen any reply indicating something has got made worse. The fact that in one case I left the xenbus_printf() in place despite having replaced the format string by one without % specifier didn't result in a bug at all. > xenbus_printf() does everything xenbus_write() can do with no loss of > readability. Yet with quite a bit higher overhead. Readability is not the point here. Jan