Re: [PATCH -next] net: hns: fix return value check in hns_dsaf_get_cfg()

[David Miller]

From: weiyj...@163.com
Date: Mon,  4 Jul 2016 15:00:58 +0000

>  
>       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ppe-base");
> -     if (!res) {
> +     if (!res)
>               res = platform_get_resource(pdev, IORESOURCE_MEM, res_idx++);
> -             if (!res) {
> -                     dev_err(dsaf_dev->dev, "ppe-base info is needed!\n");
> -                     return -ENOMEM;
> -             }
> -     }

platform_get_resource() can return NULL, you can't just remove this check.

This is also a case of a patch trying to do many things at once, and that's
why bugs like this tend to slip in.