On Tue, 2 May 2006, Francois Romieu wrote:
> The error paths are badly broken.
>
> Bonus:
> - remove duplicate initialization of sp;
> - remove useless NULL initialization of dev;
> - USE_IO_OPS is not used (and the driver does not seem to care about
> posted writes, rejoice).
>
> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
Applied. Thanks! One comment below.
On Tue, 2 May 2006, Francois Romieu wrote:
> - err = pci_request_regions(pdev, DRV_NAME);
> - if (err)
> - goto out;
> -
> - pio_start = pci_resource_start(pdev, 0) & 0xffffff80;
> - pio_len = pci_resource_len(pdev, 0);
> - mmio_start = pci_resource_start(pdev, 1) & 0xffffff80;
> + rc = pci_request_regions(pdev, DRV_NAME);
> + if (rc)
> + goto err_free_dev_1;
Is this tested with hardware? Alignment of the start address looks bogus
for sure, but any idea why they had it in the first place?
Pekka
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
