Hi David, On Wed, Jun 22, 2016 at 01:27 AM CEST, David Ahern <d...@cumulusnetworks.com> wrote: > Add -g flag to builds if DEBUG parameter is set. Improves > debugging with gdb. > > Signed-off-by: David Ahern <d...@cumulusnetworks.com> > --- > Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Makefile b/Makefile > index 15c81ecfdca3..8e006759079d 100644 > --- a/Makefile > +++ b/Makefile > @@ -39,7 +39,11 @@ HOSTCC = gcc > DEFINES += -D_GNU_SOURCE > # Turn on transparent support for LFS > DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE > +ifdef DEBUG > +CCOPTS = -g > +else > CCOPTS = -O2 > +endif > WFLAGS := -Wall -Wstrict-prototypes -Wmissing-prototypes > WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2
This implies a change of optimization level to -O0 when building with DEBUG set, doesn't it? Was it intentional? Perhaps it would be less surprising to explicitly set -O0, if that was your intention. Just a thought. Thanks, Jakub
