From: David Ahern <d...@cumulusnetworks.com> Date: Mon, 13 Jun 2016 16:02:53 -0600
> I found this helper to be unhelpful developing the VRF changes. Really > obfuscates the initialization of the flow struct. Happy to see it go. The whole point was so that it would actually be easier. If flow structures only get initialized by 2 or 3 helpers, then when adding new flow fields you only need to update the helpers. Since you have to update the helper argument signatures in order to do this, you would be forced to update all call sites and make sure they passed in suitable new argument(s). But if people don't use the helpers, and initialize flow structures on their own, yeah that defeats the whole mechanism and things will seem harder and "unhelpful". I really think this is a step backwards.
