+ netdev
On Sat, Jun 11, 2016 at 10:18 AM, Kishan Sandeep <sandeepkishan...@gmail.com> wrote: > strncpy generally perferable fo non-terminated > fixed-width strings. For NULL termination strlcpy > is preferrable. > > Signed-off-by: Kishan Sandeep <sandeepkishan...@gmail.com> > --- > net/netfilter/xt_repldata.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netfilter/xt_repldata.h b/net/netfilter/xt_repldata.h > index 8fd3241..a460211 100644 > --- a/net/netfilter/xt_repldata.h > +++ b/net/netfilter/xt_repldata.h > @@ -28,7 +28,7 @@ > if (tbl == NULL) \ > return NULL; \ > term = (struct type##_error *)&(((char *)tbl)[term_offset]); \ > - strncpy(tbl->repl.name, info->name, sizeof(tbl->repl.name)); \ > + strlcpy(tbl->repl.name, info->name, sizeof(tbl->repl.name)); \ > *term = (struct type##_error)typ2##_ERROR_INIT; \ > tbl->repl.valid_hooks = hook_mask; \ > tbl->repl.num_entries = nhooks + 1; \ > -- > 1.7.9.5 >
