From: Daniel Borkmann <dan...@iogearbox.net> Date: Thu, 09 Jun 2016 14:15:43 +0200
> On 06/09/2016 02:11 PM, Ben Dooks wrote: >> On 09/06/16 12:35, Daniel Borkmann wrote: >>> On 06/09/2016 01:07 PM, Ben Dooks wrote: >>>> The symbol ic_addrservaddr is not static, but has no declaration >>>> to match. Since the similar variables are all exported, add this >>>> one to the header file as well. >>>> >>>> This fixes the following warning: >>>> >>>> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not >>>> declared. Should it be static? >>>> >>>> Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk> >>> >>> Well, how about making it actually static if it's only used >>> from ipconfig.c ? >> >> The only reason is that I thought someone might want to >> use it in the future. I have no particular insight though. > > Usual policy is that if such thing is required, then it can be > exported along with the code that is making use of it from elsewhere. Right.
