From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 25 Apr 2006 15:16:35 -0700

> On Tue, 25 Apr 2006 14:46:49 -0700 (PDT)
> "David S. Miller" <[EMAIL PROTECTED]> wrote:
> 
> > From: Stephen Hemminger <[EMAIL PROTECTED]>
> > Date: Tue, 25 Apr 2006 10:01:49 -0700
> > 
> > > >       # Hit    # miss Function:[EMAIL PROTECTED]
> > > > !         0     50505 tcp_transmit_skb():net/ipv4/[EMAIL PROTECTED]
> >  ...
> > > How about just taking off the likely/unlikely in this case.
> > 
> > Why remove it when we'll now get a 50505 to 0 hit rate?
> 
> Depends on the data stream, but I guess if we are seeing high loss
> we really don't care about the CPU branch prediction.

I disagree, this is a hard error condition, and happens only when
af_ops->queue_xmit() cannot send the packet successfully.  Under
any normal circumstances whatsoever, it will succeed.

Are you actually looking at the right piece of code? :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to